Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed escaping on notes for file uploads #14630

Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 22, 2024

Looks like we were encoding the DB value of the notes on the asset model and asset file uploads. We already encode on the way out, so this was causing double-encoding.

Screenshot 2024-04-22 at 2 57 28 PM

Copy link

what-the-diff bot commented Apr 22, 2024

PR Summary

  • Removal of Escape Function in AssetModelFilesController
    The program's control mechanism for managing asset model files has been updated. Previously, the 'notes' field was being overly secured, leading to unnecessary complications. This PR addresses that by removing the excess security function.

  • Removal of Escape Function in AssetFilesController
    Similar to the AssetModelFilesController change, security measures in the AssetFilesController were also redundant. This PR enhances the controller's functionality for managing asset files by eliminating the unnecessary escape function from the 'notes' field.

@snipe snipe merged commit cfe39af into develop Apr 22, 2024
8 checks passed
@snipe snipe deleted the bug/sc-25377/double_encoding_assets_and_model_notes_on_upload branch April 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant