REMOVED: Dark Theme Button Text Coloring

[akemidx]

Description

Dark theme buttons when hovered became unreadable.
This removes that hover effect so the text remains readable.
The 'click' effect remains so a user will know that they clicked the button.

Additionally, a white border was added to the dark black theme buttons, and a black border was added to the dark yellow theme buttons

This affects the header search bar magnifying glass, the Back, and the Save buttons.

Fixes # SC-23235

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Visually tested in local instance

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

This Pull Request involves changes in visual elements for an improved and consistent user experience across different themes:

• Change in Black Theme
  The main button (.btn-primary) in the black theme is now outlined with white color (#FFF).

• Removal of Hovering Effect in Multiple Themes
  The color changes on hovering over the main button on the blue, green, orange, purple, and red themes have been removed. This simplifies user interactions and ensures consistency across themes.

• Change in Yellow Theme
  The main button (.btn-primary) in the yellow theme is updated to have a black color (#000000) outline, enhancing its visibility and contrast against the yellow background.