-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added signature to user print report for Accessories and Consumables #14500
Added signature to user print report for Accessories and Consumables #14500
Conversation
PR Summary
|
This pull request has been linked to Shortcut Story #25118: include accessory acceptance signature on Print All Assigned reports. |
That last fix will break the table layout though, since the header has a spot for signature. We'd have 6 table headers but potentially only 5 table columns. Something more like <td>
@if (($accessory->assetlog->first()) && ($accessory->assetlog->first()->accept_signature!=''))
<img style="width:auto;height:100px;" src="{{ accessory('/') }}display-sig/{{ $accessory->assetlog->first()->accept_signature }}">
@endif
</td> like we do for assets. |
Per [SC-20725] can we add the signature column for the other types of items as well? |
This pull request has been linked to Shortcut Story #20725: Require signature for Accessories, Consumables and Components. |
Ack, I think we already have the feature from [SC-20725], don't we? If not, it's out of scope for this PR anyway. If we do have those implemented, let's make sure we're exposing those signatures in the print page as well. |
@snipe currently we have consumables, accessories and assets. We will need to build signing out for components and licenses. (that commit should say consumables not components..Components on the brain) |
Can you retarget this to |
Description
Added the signature for accessory and consumable acceptances to users' print all report.

Fixes # (issue)
[sc-25118]
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: