Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dead test code #14437

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Removed dead test code #14437

merged 3 commits into from
Mar 18, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This small PR cleans up some dead code from tests by deleting a couple test files that only contain commented code and deleting commented test cases.

Type of change

  • Chore

@marcusmoore marcusmoore requested a review from snipe as a code owner March 14, 2024 20:15
Copy link

This pull request has been linked to Shortcut Story #25070: Remove unused test case files.

Copy link

what-the-diff bot commented Mar 14, 2024

PR Summary

  • Simplification of UpdateUserApiTest.php
    This change has simplified the UpdateUserApiTest.php file by removing any unnecessary complexity. The InteractsWithAuthentication trait was removed to make the code cleaner, overall improving the user update operation tests.

  • Tidy Up CategoryTest.php
    This PR improved the quality of the CategoryTest.php file by removing commented out test methods. It ensures that the code is cleaner and more maintainable, positively impacting the testing process for categories.

@snipe snipe merged commit ec2c581 into snipe:develop Mar 18, 2024
8 checks passed
@marcusmoore marcusmoore deleted the chore/sc-25070 branch March 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants