Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added route parameter #14372

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Added route parameter #14372

merged 1 commit into from
Mar 6, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 5, 2024

This was causing a rollbar in certain circumstances with:

Missing required parameter for [Route: hardware.show] [URI: hardware/{hardware}] [Missing parameter: hardware]

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #24158: Illuminate\Routing\Exceptions\UrlGenerationException: Missing required parameter for [Route: hardware.show] [URI: hardware/{hardware}] [Missing parameter: hardware]. in /snipe-it/vendor/laravel/framework/src/Illuminate/Routing/Exceptions/UrlGenerationExce.

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Mar 5, 2024

PR Summary

  • Modification to the 2D Barcode Rendering Process
    This pull request alters the way we generate a 2D barcode for our hardware assets. The route for displaying these assets has been updated. This change ensures that each 2D barcode correctly leads to its corresponding asset's detailed info page in our app.

@snipe snipe merged commit a85e2f7 into develop Mar 6, 2024
8 checks passed
@snipe snipe deleted the bug/sc-24158 branch March 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snipe