Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds User email check when sending Asset acceptance reminder #14371

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Mar 5, 2024

if you sent an asset acceptance reminder to a user and they didnt have an email it would default to sending the default notification you had setup under integrations.

image

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context, providing screenshots where practical. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Mar 5, 2024

PR Summary

  • Improved Error Management in Reports Controller
    Added mechanisms in the ReportsController.php to guide user navigation. The system now checks if an assigned asset has an associated email address. If not, it redirects users to a specific space with an error message, ensuring users are always informed.

  • Feedback Enhancement for Successful Actions
    To improve user experience, the ReportsController.php now redirects users to a unique route with a success message after certain actions. Users will receive more direct feedback on the status of their operations.

  • Localization Update
    An additional translation string has been incorporated in general.php within the en-US language folder for better communication. The new string ensures users understand there's no email associated with their user account when relevant.

@snipe snipe merged commit 4231058 into snipe:develop Mar 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants