Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy encrypted custom fields #14335

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Copy encrypted custom fields #14335

merged 2 commits into from
Feb 28, 2024

Conversation

mauro-miatello
Copy link
Contributor

Description

Encrypted custom fields may contain sensitive or important information, and it may be useful to have the ability to copy them.
If there are multiple tooltips, they all report the message "copied" because there is no element selection. This fix resolves the issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have tested in my on-premise installation:

  • Created multiple encrypted custom fields
  • Copied each of them
  • Checked that in license the copy feature is not broker

Test Configuration:

  • PHP version: 8.0.30
  • MySQL version: MariaDB 10.3.38
  • Webserver version: Apache 2.4.58
  • OS version: Ubuntu 20.04.6 LTS

Checklist:

Encrypted custom fields may contain sensitive or important information, and it may be useful to have the ability to copy them.
If there are multiple tooltips, they all report the message "copied" because there is no element selection. This fix resolves the issue.
Copy link

what-the-diff bot commented Feb 25, 2024

PR Summary

  • Improved User Interface on Hardware View
    The interface of the 'hardware view' page has been updated to improve user interaction. New interactive elements have been added, including a 'copy' feature that allows users to quickly copy relevant information. Additionally, a direct link to the application's Twitter account has been added for easy access to updates and news.

  • Improved Website Layout and Interactivity
    The overall layout of the website has received enhancements. There's a new function related to the ClipboardJS library, which enhances the copying feature for user interaction. Also, updates related to tooltips (small informative pop-ups that appear when you hover over certain elements) have been incorporated, providing users with helpful information and guidance while using the application.

@mauro-miatello
Copy link
Contributor Author

"Additionally, a direct link to the application's Twitter account has been added for easy access to updates and news." is an allucination 😄

@snipe
Copy link
Owner

snipe commented Feb 28, 2024

lol AI isn't coming for our jobs any time soon

@snipe snipe merged commit fcb2bf7 into snipe:develop Feb 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants