-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests around asset check in and added missing actions to the api controller action #14260
Conversation
This pull request has been linked to Shortcut Story #24808: Add tests around asset check in. |
PR Summary
|
Description
This PR adds tests around asset check-in via the web and API endpoints. In the process I added some missing actions that the web controller contained that were missing from the api controller:
0
tonull/''
update_default_location=true
field to update the asset'srtd_location_id
to the providedlocation_id
.0
instead oftrue
I did some test organization and controller code clean up to make things a little easier to follow as well.
Something to note: providing a
checkin_at
via the web results in theaction_date
in the action log being{provided_date} 00:00:00
. The api behavior differs by taking the providedcheckin_at
and adding the current time (if the request happens at 8:37:01am then the result is{provided_date} 08:37:01
. Let me know if I should bring that behavior in sync.Type of change