Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LDAP group tag to LDAP tests #14255

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR simply adds the @group annotation to the LDAP tests so they can be skipped by developers that do not the LDAP extension installed.

php artisan test --exclude-group=ldap

Of course there are other opportunities for grouping tests but this focuses on just LDAP.

Type of change

  • Chore

Copy link

This pull request has been linked to Shortcut Story #24805: Allow LDAP tests to be skipped.

Copy link

what-the-diff bot commented Feb 12, 2024

PR Summary

  • Update to Test Suite Command
    The method for executing the complete test suite has been revised in the 'Testing' guide. This change now includes syntax highlighting in the related code, making it more user-friendly and easy to follow.

  • Enhanced Examples in Testing Guide
    The 'Testing' guide now includes added examples of how to run individual tests and execute tests with specific groups. The examples also feature syntax highlighting for ease of understanding and usage.

  • New Categorization of Test Case in LdapTest
    The 'LdapTest.php' file now includes a new categorization annotation that labels the associated test case as part of the 'ldap' group. This update aids in organization and easy identification of test cases belonging to certain groups.

@snipe snipe merged commit 60ba898 into snipe:develop Feb 13, 2024
@marcusmoore marcusmoore deleted the chore/sc-24805 branch February 13, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants