Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed user total asset cost to appear conditionally #13954

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 27, 2023

Description

This enhancement will only show an asset breakdown for a user if they have an asset assigned to them that have a cost associated with it:
image
No cost, No breakdown:
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

@Godmartinz Godmartinz changed the title makes user total asset cost appear conditionally Fixed user total asset cost to appear conditionally Nov 27, 2023
@Godmartinz Godmartinz requested a review from snipe November 27, 2023 19:42
Copy link

what-the-diff bot commented Nov 27, 2023

PR Summary

  • Enhanced User Cost Display
    The team has improved how user's total cost information is displayed. Now, a new condition ensures this detailed cost data is only shown when it's actually applicable (i.e., when a user's total cost is greater than 0). This helps in keeping the interface clean and free of irrelevant information.

  • Added Conditional Section
    An additional section was created to show more specific details about the user's cost, but it only appears when certain conditions are met. This provides users with optional information only when it's relevant, making the overall user experience more intuitive.

@Godmartinz Godmartinz requested a review from snipe November 28, 2023 18:10
@snipe snipe merged commit 189c90e into snipe:develop Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants