Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default map back to the importer #13876

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Nov 14, 2023

This is basically a reversal of d228b7f, but with some added comments. When we refactored the importer to make it more Livewire-y, we pulled out a variable that we thought we didn't need anymore. It's only come up recently because some folks use the cli importer a lot more than we realized, and that commit broke the cli for them.

We do need to find a way to make this less duplicative, either by importing the variables from the Livewire side, or vice versa. This should at least fix the cli importer for now, and won't interfere with the GUI importer.

Copy link

what-the-diff bot commented Nov 14, 2023

PR Summary

  • Addition of User ID attribute
    A protected user_id attribute was added in Importer.php. This inclusion allows for the identification of the specific user making particular changes, enhancing traceability.

  • Inclusion of Update State attribute
    Another attribute named updating has been inserted. This enables the system to better recognize and handle instances when an update is ongoing, improving system responsiveness.

  • Introduction of Default Field Map
    A $defaultFieldMap array has been introduced with several key-value pairs. The addition of this attribute improves the mapping and handling of fields and their default values, thereby making operations more seamless and efficient.

@snipe snipe deleted the fixes/added_fieldmap_back_for_cli_import branch November 14, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant