Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi location sync for ldap #13831

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 2, 2023

Description

Adds the ability to sync multiple location OUs at once.
image
Shout out to @marcusmoore for assistance with input arrays.

working on getting some helpful error messaging if 1 out of 10 locations doesnt work, you know which one etc.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Nov 2, 2023

PR Summary

  • Enhanced LDAP Synchronization
    The snipeit:ldap-sync command has been upgraded to permit the inclusion of multiple location IDs. This change enhances the flexibility and efficiency of LDAP user import, as users from many locations can be imported simultaneously.

  • Debug Logging in LDAP Sync
    The same snipeit:ldap-sync command will now record debug messages during the import process. This improvement aids troubleshooting and process tracking during user imports.

  • Improved LDAP Import Controller
    The LDAPImportController@store method has been altered to facilitate multiple location IDs, akin to the enhancement in snipeit:ldap-sync command. Therefore, the similar benefit of flexibility gets extended to the method call as well.

  • LDAP Form View Modification
    The visual interface for selecting locations in the LDAP form has been optimized. Now, it manifests as a multiple select dropdown menu, which makes the location selection much easier and more intuitive.

@snipe snipe merged commit 4ecce51 into snipe:develop Nov 13, 2023
@snipe
Copy link
Owner

snipe commented Nov 13, 2023

This looks great, thanks @Godmartinz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants