Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13251 - ldap_location attribute #13322

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

uberbrady
Copy link
Collaborator

A customer [FD-36851] reports that his locations were being unset in his per-location-specific various LDAP syncs.

It seems like we'll override the Location that a user would be assigned if they were using the --location command-line option, even if the user had not configured the LDAP Location field.

This adds a guard clause that will only try to override the location if the field is being used.

@what-the-diff
Copy link

what-the-diff bot commented Jul 17, 2023

PR Summary

  • Modification to LdapSync.php
    The LdapSync.php file within our application has been updated for enhanced functionality.

  • Addition of conditional statement
    A new rule has been introduced that checks two things before proceeding - it verifies whether the 'ldap_result_location' setting is enabled and also if the item's location information isn't empty.

  • Creation of Location entry
    Provided that our newly implemented conditions are met, the system will then proceed to create a fresh 'Location' entry utilizing the given location data.

  • Advantages of the new changes
    This refined approach ensures that new Location entries are created more responsibly, conditioned on necessary prerequisites being satisfied, increasing the overall efficiency of our system. This means we avoid creating redundant or unnecessary Location entries, streamlining our data management.

@snipe snipe merged commit 6f8c3ca into snipe:develop Jul 18, 2023
@snipe snipe changed the title Fix to ldap_location attribute Fixes #13251 - ldap_location attribute Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants