Fix formatting and linting. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 12, 2019 10:25
In first place, let me apologize. I needed to fix the Finnish formatting but linting got into my editor's way so this is the complete list of changes: - Fix formatting for a few languages. Some languages include a dot in the short format and in the data we get that dot surrounded by single quotes. This is the main reason for this PR. - Make the project pass its linting rules. - Make CI check linting. - Fix path in tslint.json to properly exclude test/locale-data.ts - Add test/locale-data.ts to .prettierignore
Jest is having a problem with latest unstable node (11.11.0) facebook/create-react-app#6591 so trying to set specific supported versions to fix travis
snewcomer
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In first place, let me apologize for too many changes in one PR. I needed to fix the Finnish formatting
but linting got into my editor's way so this is the complete list of
changes:
the short format and in the data we get that dot surrounded by single
quotes. This is the main reason for this PR.