-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debounce by updating popover returnFocus #496
Conversation
Test Environment for snehilvj/dash-mantine-components-496 |
popoverProps={{returnFocus: true}} | ||
{...others} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we want to merge this with any popoverProps
you provide explicitly? ie pull popoverProps
out of props
, then here:
popoverProps={{returnFocus: true, ...popoverProps}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice catch - yes, that's how it should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That needs to be applied to #471 too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
closes #495
When
debounce=True
, the value is updated when the input loses focus.In a recent Mantine update, they changed the default popover prop
returnFocus
to false, which meant that the Input wasn't focused after the dates were selected. This broke the debounce because it wasn't possible to update the value when the input loses focus.