Fix DateInput #314
Merged
Fix DateInput #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnMarieW
requested review from
alexcjohnson
and removed request for
snehilvj
|
Two usage questions:
|
|
The issue was that the locale wasn't working when the component first rendered. I'll try your solution and see if it works - I'll also verify with the two usage items too. Thanks for the suggestions 🙂 |
|
@alexcjohnson This is now ready - and verified that additional use-cases work 🎉 |
|
Thanks @AnnMarieW for working on this, I just used my own version because of this issue, but I will be back to using this one once it is updated in PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #308
fixes #249
fixes #203
fixes #264
This PR is based on PR #265 by @albavilanova
@albavilanova Thanks so much for your PR. This new one is based on your work and includes a few sample apps for testing. I was reluctant to update your PR because I understand you are using your own version of dmc in production. If you would like to continue to work on this, let me know and I'll close this PR in favor of yours. Otherwise we can carry on with this one and we'll give you credit in the Changelog when it's merged.
This PR also enables the date parsing to work with the
DateInputcomponent even when theDateProvideris not being used.@snehil - was there any reason not to merge the original PR 265?
Note - The three sample apps for testing are in the
usage-265folder and can be deleted after merging.