Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MonthPickerInput & YearPickerInput #255 #266

Merged
merged 10 commits into from
Sep 7, 2024

Conversation

stpnvkirill
Copy link
Contributor

@Ferreira-B
Copy link

Any news on this? It would be a very nice feature to have in DMC.

@michaelrussell4
Copy link

Yes, just what I was looking for. Glad someone added it. Please merge.

@hdowens
Copy link

hdowens commented Aug 14, 2024

Any update on this? Would be super useful

@AnnMarieW
Copy link
Collaborator

Hi @stpnvkirill

Sorry for the delay - this has been a popular request!

This PR looks really good - just needs a few minor updates, then it's good to go.

  • The component names need to be changed to MonthPickerInput and YearPickerInput since the upstream Mantine library has both MonthPicker and MonthPickerInput components and we may want to include both versions at some point in the future.
  • Remove the console.log
  • update with the latest changes from the dmc master branch
  • add a Changelog enttry.

Let me know if you would like to make the updates. I could also make the changes if you prefer since you have enabled maintainers to edit.

@snehilvj - This would be a nice addition - I verified that all the examples in the upstream Mantine docs work so adding this the dmc-docs will be easy.

@stpnvkirill
Copy link
Contributor Author

@AnnMarieW Hello!

I have corrected the code

@AnnMarieW
Copy link
Collaborator

@stpnvkirill

Thank for the updates! Could you please exclude the package-lock.json file?
Next, I'll run this updated version with the docs app to make sure everything works over there - then it will be ready for @snehilvj's final review .

I'm looking forward to getting this into the next release!

@stpnvkirill
Copy link
Contributor Author

@AnnMarieW Please tell me what it means to exclude the package-lock file.json?

Do you want me to delete this file? git rm --cached package-lock.json

@AnnMarieW
Copy link
Collaborator

@stpnvkirill Unless you changed the dependencies, the package-lock.json file should not be committed and pushed in the PR. I’m not sure how to undo that, but the file can’t be deleted - it needs to remain unchanged from the current version on the main branch.

@snehilvj
Copy link
Owner

snehilvj commented Sep 7, 2024

I tried to handle the package-lock.json file from the Github UI but got that wrong. Will merge this PR for now and will handle it in a commit on top of this merge.

@snehilvj snehilvj merged commit e5e645f into snehilvj:master Sep 7, 2024
@snehilvj
Copy link
Owner

snehilvj commented Sep 7, 2024

Thanks @stpnvkirill and Ann for this PR and review respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants