-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MonthPickerInput & YearPickerInput #255 #266
Conversation
Any news on this? It would be a very nice feature to have in DMC. |
Yes, just what I was looking for. Glad someone added it. Please merge. |
Any update on this? Would be super useful |
Hi @stpnvkirill Sorry for the delay - this has been a popular request! This PR looks really good - just needs a few minor updates, then it's good to go.
Let me know if you would like to make the updates. I could also make the changes if you prefer since you have enabled maintainers to edit. @snehilvj - This would be a nice addition - I verified that all the examples in the upstream Mantine docs work so adding this the dmc-docs will be easy. |
@AnnMarieW Hello! I have corrected the code |
Thank for the updates! Could you please exclude the package-lock.json file? I'm looking forward to getting this into the next release! |
@AnnMarieW Please tell me what it means to exclude the package-lock file.json? Do you want me to delete this file? |
@stpnvkirill Unless you changed the dependencies, the package-lock.json file should not be committed and pushed in the PR. I’m not sure how to undo that, but the file can’t be deleted - it needs to remain unchanged from the current version on the main branch. |
I tried to handle the package-lock.json file from the Github UI but got that wrong. Will merge this PR for now and will handle it in a commit on top of this merge. |
Thanks @stpnvkirill and Ann for this PR and review respectively. |
2 components have been added:
https://mantine.dev/dates/month-picker-input/
https://mantine.dev/dates/year-picker-input/