Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter AP outbox and /convert/... by account status #1248

Open
snarfed opened this issue Aug 9, 2024 · 3 comments
Open

Filter AP outbox and /convert/... by account status #1248

snarfed opened this issue Aug 9, 2024 · 3 comments
Labels
parity Features supported by two or more protocols, but not yet bridged between them.

Comments

@snarfed
Copy link
Owner

snarfed commented Aug 9, 2024 •
edited
Loading

Details in GHSA-6q9w-mpqc-j4j4. Thanks again @qazmlp!
@snarfed snarfed added the now label Aug 9, 2024
snarfed added a commit that referenced this issue Aug 12, 2024
@snarfed
noop: Protocol.targets refactoring, source protocol isn't in to_proto…
e21dabe 
…cols

for #1248
snarfed added a commit that referenced this issue Aug 12, 2024
@snarfed
/convert/: check that object (if necessary) and user are bridged
fa17025 
for #1248, https://github.com/snarfed/bridgy-fed/security/advisories/GHSA-6q9w-mpqc-j4j4
snarfed added a commit that referenced this issue Aug 12, 2024
@snarfed
/convert/: for reposts, check that original post and author are bridged
39aa16b 
for #1248, https://github.com/snarfed/bridgy-fed/security/advisories/GHSA-6q9w-mpqc-j4j4
@snarfed
Copy link
Owner Author

snarfed commented Aug 12, 2024

Progress here, I think I've fixed this for /convert/.... Fixing outbox has been trickier, and different, but it's coming along.

snarfed added a commit that referenced this issue Aug 14, 2024
@snarfed
temporarily disable outboxes
775756c 
for #1248
snarfed added a commit that referenced this issue Aug 14, 2024
@snarfed
AP outbox: turn off querying too
4c12c08 
for #1248
@snarfed
Copy link
Owner Author

snarfed commented Aug 14, 2024

I've disabled outboxes for now. Unfortunate, but fixing them the right way will take some nontrivial refactoring. I'll track all of that in this issue.

snarfed added a commit that referenced this issue Aug 15, 2024
@snarfed
/convert/: when checking that author is bridged, handle cross-protoco…
b5a1f32 
…l reposts

for #1248, https://console.cloud.google.com/errors/detail/CJmhz9SqmcO6vQE;time=P7D;locations=global?project=bridgy-federated
@snarfed snarfed mentioned this issue Aug 18, 2024
Open
@snarfed snarfed removed the now label Sep 11, 2024
@Tamschi Tamschi mentioned this issue Oct 31, 2024
Open
@Tamschi Tamschi added the parity Features supported by two or more protocols, but not yet bridged between them. label Oct 31, 2024
@Tamschi
Copy link
Collaborator

Tamschi commented Oct 31, 2024

I'll label this just parity since only the outbox collection is missing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parity Features supported by two or more protocols, but not yet bridged between them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tamschi @snarfed