Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I have given adding
Bytes
a try but I at some places I am not sure if there is a performance implication or not. This is a continuation of #104. This is the first time for me working with more low level network stuff so I might be missing one or two obvious things.The breaking change here would be for users that use
Message::Binary())
instead ofMessage::binary()
to construct the message. The fix for this is quite simple as they would have to just change it toMessage::Binary(data.into()))
.Let me know what you think.
Thanks a lot and have a great day!