Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Replace Vec<u8> with Bytes #461

Closed
wants to merge 2 commits into from

Conversation

Zarathustra2
Copy link

Hi I have given adding Bytes a try but I at some places I am not sure if there is a performance implication or not. This is a continuation of #104. This is the first time for me working with more low level network stuff so I might be missing one or two obvious things.

The breaking change here would be for users that use Message::Binary()) instead of Message::binary() to construct the message. The fix for this is quite simple as they would have to just change it to Message::Binary(data.into())).

Let me know what you think.

Thanks a lot and have a great day!

@Zarathustra2
Copy link
Author

Oh didn't realize someone already did the work in #175 in a better job, so closing this in favor of that PR. My bad, should have taken a better look at the already open PRs, not sure how I didn't notice it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant