Fix the echo server example to prevent ConnectionClosed error #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
suggested changes
Sep 10, 2021
daniel-abramov
requested changes
Sep 14, 2021
Related #188 The echo server would generate ConnectionClosed error when the peer close the connection normally. This is because that `tungstenite` crate automatically reply Close message to the peer. Then StreamExt::forward() also forwards the Close message after the connection is closed.
daniel-abramov
approved these changes
Sep 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #188
The echo server would generate ConnectionClosed error when the peer close the connection normally.
This is because that
tungstenitecrate automatically reply Close message to the peer.Then
StreamExt::forward()also forwards the Close message after the connection is closed.