Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dockerfile #98

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Remove Dockerfile #98

merged 3 commits into from
Feb 15, 2021

Conversation

mbhall88
Copy link
Member

Removed

  • Dockerfile has been removed as the biocontainers images are smaller and some recent changes to the cryptography dependency require Rust to be installed (on Alpine) which further bloats our DockerHub image.

@mbhall88 mbhall88 requested a review from bricoletc February 14, 2021 08:55
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #98 (3534f77) into master (1ec8b83) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          11       11           
  Lines         889      889           
  Branches      163      163           
=======================================
  Hits          873      873           
  Misses          8        8           
  Partials        8        8           
Flag Coverage Δ
unittests 98.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@bricoletc bricoletc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but think we should still provide an example of how to run the image using docker and singu.

@bricoletc
Copy link
Collaborator

bricoletc commented Feb 14, 2021

Feel free to merge once the requested changes are in- also, I made a fix to #96 in branch fix_96 so we could make a new version after I push that in, after this PR is merged

@mbhall88
Copy link
Member Author

Fair point. I've added an example of using it with both Docker and Singularity.

I made a fix to #96 in branch fix_96 so we could make a new version after I push that in, after this PR is merged

Perfect. Yep, once you've merged that fix in we can release a new version.

@mbhall88 mbhall88 merged commit cd1ae84 into snakemake:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants