Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #78 #82

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Address #78 #82

merged 3 commits into from
Nov 12, 2020

Conversation

bricoletc
Copy link
Collaborator

@mbhall88 should we do a new release after these changes?

Nested if/else python code interleaved with snakemake keywords were
losing indentation. Add a fix, with unit test.
@bricoletc bricoletc requested a review from mbhall88 as a code owner November 11, 2020 07:50
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #82 (f4cdba0) into dev (c93e6bf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #82   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files           9        9           
  Lines         789      791    +2     
  Branches      146      146           
=======================================
+ Hits          770      772    +2     
  Misses          9        9           
  Partials       10       10           
Flag Coverage Δ
unittests 97.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
snakefmt/formatter.py 99.50% <100.00%> (+<0.01%) ⬆️

Copy link
Member

@mbhall88 mbhall88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Yeah, a new version (0.2.4) would be good. You want me to do it or are you ok to do it once you merge this?

@bricoletc
Copy link
Collaborator Author

Yes, very happy for you to
I added a commit adding pre-commit to the table of contents in the README, and reformatting the pre-commit yaml (I tested it, it works!)

@mbhall88 mbhall88 merged commit 03f6ed0 into snakemake:dev Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants