Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: triple-quoted f-strings #56

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Fix: triple-quoted f-strings #56

merged 5 commits into from
Jun 30, 2020

Conversation

mbhall88
Copy link
Member

closes #55

bricoletc and others added 3 commits June 29, 2020 19:45
@bricoletc
Fix #55
d7bab0d 
Bugfix: Triple quoted string formatting was being performed unduly;
it is now only performed when the tpq is 'docstring-like', eg
documenting a rule or as a parameter to the shell directive.
@mbhall88
update changelog
42a3470
@mbhall88
bump patch version
f06df94
@mbhall88 mbhall88 removed the request for review from johanneskoester June 30, 2020 02:16
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited
Loading

Codecov Report

Merging #56 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files           9        9           
  Lines         764      766    +2     
  Branches      138      139    +1     
=======================================
+ Hits          742      744    +2     
  Misses         11       11           
  Partials       11       11
Flag Coverage Δ
#unittests 97.12% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
snakefmt/formatter.py 99.44% <100.00%> (+<0.01%) ⬆️

@mbhall88 mbhall88 requested a review from bricoletc June 30, 2020 03:55
@mbhall88
Copy link
Member Author

@bricoletc it seems your change to the triple-quoted string regex means we now don't hit this line with our tests https://codecov.io/gh/snakemake/snakefmt/compare/13823170c3d4aaebf6f67cbb94319dc45804ff45...f06df94cb2a28542d7f9b413f71c8dfe7a101842/changes#D1-178

@bricoletc bricoletc merged commit 5b80063 into master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricoletc bricoletc bricoletc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

f-strings with triple quoted strings break
2 participants
@mbhall88 @bricoletc