Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retries to grammar #145

Closed
wants to merge 6 commits into from
Closed

Conversation

maarten-k
Copy link

snakemake 7.7 introduces the retries keyword. This pull request makes snakefmt also recognise this keyword.

@maarten-k maarten-k requested a review from mbhall88 as a code owner May 17, 2022 08:19
@maarten-k maarten-k changed the title feat : add retries to grammar feat: add retries to grammar May 17, 2022
@mbhall88
Copy link
Member

mbhall88 commented May 17, 2022

Thanks @maarten-k. Can you please also push the updated poetry.lock file? If you aren't using poetry, I can always add this in with #136

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #145 (83ceb49) into master (d233dfa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          12       12           
  Lines         949      949           
  Branches      211      211           
=======================================
  Hits          932      932           
  Misses         10       10           
  Partials        7        7           
Flag Coverage Δ
unittests 98.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
snakefmt/parser/grammar.py 100.00% <ø> (ø)

@mbhall88 mbhall88 changed the base branch from master to dev May 19, 2022 00:38
@mbhall88
Copy link
Member

@maarten-k, if it's okay with you, I might move this over to #136 as I don't want to mess with the commits from dev I've already pulled in on that PR

@maarten-k
Copy link
Author

@maarten-k, if it's okay with you, I might move this over to #136 as I don't want to mess with the commits from dev I've already pulled in on that PR

That is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants