Skip to content

Commit

Permalink
Adhere to lintage
Browse files Browse the repository at this point in the history
  • Loading branch information
Lukasz A.J. Wrona committed Sep 19, 2017
1 parent b544a4b commit 751e8f5
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 22 deletions.
2 changes: 1 addition & 1 deletion src/solvers/refinement/bv_refinement.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class bv_refinementt:public bv_pointerst
bool refine_arithmetic=true;
};
public:
struct infot : public configt
struct infot:public configt
{
const namespacet *ns=nullptr;
propt *prop=nullptr;
Expand Down
44 changes: 25 additions & 19 deletions src/solvers/refinement/string_refinement.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ optionalt<string_exprt> expr_cast<string_exprt>(const exprt& expr)
}

template<typename T>
T expr_cast_v(const exprt& expr) {
T expr_cast_v(const exprt& expr)
{
const auto maybe=expr_cast<T>(expr);
INVARIANT(maybe, "Bad conversion");
return *maybe;
Expand Down Expand Up @@ -535,7 +536,8 @@ std::vector<exprt> concretize_results(
const std::map<exprt, std::set<exprt>>& current_index_set,
const std::vector<string_constraintt> &universal_axioms)
{
for(const auto &it : symbol_resolve) {
for(const auto &it : symbol_resolve)
{
concretize_string(
get,
found_length,
Expand All @@ -547,7 +549,8 @@ std::vector<exprt> concretize_results(
ns,
it.second);
}
for(const auto &expr : created_strings) {
for(const auto &expr : created_strings)
{
concretize_string(
get,
found_length,
Expand Down Expand Up @@ -654,7 +657,7 @@ void string_refinementt::set_to(const exprt &expr, bool value)
{
if(is_char_array(ns, rhs.type()))
{
for (const auto& lemma : set_char_array_equality(lhs, rhs))
for(const auto& lemma : set_char_array_equality(lhs, rhs))
add_lemma(lemma, false);
}
const bool not_handled=add_axioms_for_string_assigns(
Expand All @@ -665,7 +668,7 @@ void string_refinementt::set_to(const exprt &expr, bool value)
ns,
lhs,
subst_rhs);
if (!not_handled)
if(!not_handled)
return;
}

Expand Down Expand Up @@ -753,7 +756,7 @@ decision_proceduret::resultt string_refinementt::dec_solve()
symbol_resolve);
if(!success)
{
for (const auto& lemma : lemmas)
for(const auto& lemma : lemmas)
add_lemma(lemma);
debug() << "check_SAT: got SAT but the model is not correct" << eom;
}
Expand All @@ -772,16 +775,16 @@ decision_proceduret::resultt string_refinementt::dec_solve()
initial_index_set(index_set, current_index_set, ns, universal_axioms);
update_index_set(index_set, current_index_set, ns, cur);
cur.clear();
for (const auto& lemma :
generate_instantiations(current_index_set, universal_axioms))
for(const auto& lemma :
generate_instantiations(current_index_set, universal_axioms))
add_lemma(lemma);
display_current_index_set(debug(), ns, current_index_set);

while((loop_bound_--)>0)
{
decision_proceduret::resultt res=supert::dec_solve();

if (res == resultt::D_SATISFIABLE)
if(res==resultt::D_SATISFIABLE)
{
bool success;
std::vector<exprt> lemmas;
Expand All @@ -798,7 +801,7 @@ decision_proceduret::resultt string_refinementt::dec_solve()
symbol_resolve);
if(!success)
{
for (const auto& lemma : lemmas)
for(const auto& lemma : lemmas)
add_lemma(lemma);
debug() << "check_SAT: got SAT but the model is not correct" << eom;
}
Expand All @@ -821,7 +824,7 @@ decision_proceduret::resultt string_refinementt::dec_solve()
current_index_set.clear();
update_index_set(index_set, current_index_set, ns, cur);
cur.clear();
for (const auto& lemma :
for(const auto& lemma :
generate_instantiations(current_index_set, universal_axioms))
add_lemma(lemma);
display_current_index_set(debug(), ns, current_index_set);
Expand All @@ -843,7 +846,7 @@ decision_proceduret::resultt string_refinementt::dec_solve()
generator.get_created_strings(),
current_index_set,
universal_axioms);
for (const auto& lemma : lemmas)
for(const auto& lemma : lemmas)
add_lemma(lemma);
display_current_index_set(debug(), ns, current_index_set);
return resultt::D_SATISFIABLE;
Expand All @@ -867,7 +870,9 @@ decision_proceduret::resultt string_refinementt::dec_solve()
for(const exprt &lemma : lemmas)
add_lemma(lemma);
}
} else {
}
else
{
debug() << "check_SAT: default return " << static_cast<int>(res) << eom;
return res;
}
Expand Down Expand Up @@ -1923,7 +1928,8 @@ class find_index_visitort: public const_expr_visitort
/// \param [in] str: the string which must be indexed
/// \param [in] qvar: the universal variable that must be in the index
/// \return an index expression in `expr` on `str` containing `qvar`
static exprt find_index(const exprt &expr, const exprt &str, const symbol_exprt &qvar)
static exprt find_index(
const exprt &expr, const exprt &str, const symbol_exprt &qvar)
{
find_index_visitort v(str, qvar);
expr.visit(v);
Expand Down Expand Up @@ -1972,7 +1978,8 @@ static std::vector<exprt> instantiate_not_contains(
// << from_expr(ns, "", s1) << eom;
const auto& i0=index_set.find(s0.content());
const auto& i1=index_set.find(s1.content());
if (i0 != index_set.end() && i1 != index_set.end()) {
if(i0!=index_set.end() && i1!=index_set.end())
{
return ::instantiate_not_contains(
axiom, i0->second, i1->second, generator);
}
Expand Down Expand Up @@ -2025,9 +2032,8 @@ exprt substitute_array_lists(exprt expr, size_t string_max_length)
/// \return an expression
exprt string_refinementt::get(const exprt &expr) const
{
const auto super_get = [this](const exprt& expr) {
return supert::get(expr);
};
const auto super_get=[this](const exprt& expr)
{ return supert::get(expr); };
exprt ecopy(expr);
replace_expr(symbol_resolve, ecopy);
if(is_char_array(ns, ecopy.type()))
Expand All @@ -2047,7 +2053,7 @@ exprt string_refinementt::get(const exprt &expr) const
}
else if(ecopy.id()==ID_struct)
{
if (const auto string=expr_cast<string_exprt>(ecopy))
if(const auto string=expr_cast<string_exprt>(ecopy))
{
const exprt &content=string->content();
const exprt &length=string->length();
Expand Down
6 changes: 4 additions & 2 deletions src/solvers/refinement/string_refinement.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ Author: Alberto Griggio, [email protected]
class string_refinementt final: public bv_refinementt
{
private:
struct configt {
struct configt
{
unsigned refinement_bound=0;
/// Make non-deterministic character arrays have at least one character
bool string_non_empty=false;
Expand Down Expand Up @@ -98,5 +99,6 @@ class string_refinementt final: public bv_refinementt
};

exprt substitute_array_lists(exprt expr, size_t string_max_length);
exprt concretize_arrays_in_expression(exprt expr, std::size_t string_max_length);
exprt concretize_arrays_in_expression(
exprt expr, std::size_t string_max_length);
#endif

0 comments on commit 751e8f5

Please sign in to comment.