Merge pull request diffblue#1811 from cesaro/iterator-fix

Fixes the symbol_base_tablet iterator
smowton · Feb 8, 2018 · 2c69364 · 2c69364
2 parents 0df054c + 807268e
commit 2c69364
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/util/symbol_table_base.h b/src/util/symbol_table_base.h
@@ -144,6 +144,11 @@ class symbol_table_baset
     typedef symbolst::const_iterator::reference reference;           // NOLINT
     typedef symbolst::iterator::iterator_category iterator_category; // NOLINT
 
+    bool operator!=(const iteratort &other) const
+    {
+      return it != other.it;
+    }
+
     bool operator==(const iteratort &other) const
     {
       return it == other.it;

diff --git a/unit/util/symbol_table.cpp b/unit/util/symbol_table.cpp
@@ -5,6 +5,25 @@
 #include <testing-utils/catch.hpp>
 #include <util/journalling_symbol_table.h>
 
+TEST_CASE("Iterating through a symbol table", "[core][utils][symbol_tablet]")
+{
+  symbol_tablet symbol_table;
+
+  symbolt symbol;
+  irep_idt symbol_name = "Test";
+  symbol.name = symbol_name;
+
+  symbol_table.insert(symbol);
+
+  int counter = 0;
+  for(auto &entry : symbol_table)
+  {
+    ++counter;
+  }
+
+  REQUIRE(counter == 1);
+}
+
 SCENARIO("journalling_symbol_table_writer",
   "[core][utils][journalling_symbol_table_writer]")
 {