This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Export stack outputs #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include Subnet Groups in outputs
|
Please rebase |
jplock
reviewed
Jul 21, 2019
src/index.js
Outdated
| @@ -105,6 +106,10 @@ class ServerlessVpcPlugin { | |||
| if ('createNatInstance' in vpcConfig && typeof vpcConfig.createNatInstance === 'boolean') { | |||
| ({ createNatInstance } = vpcConfig); | |||
| } | |||
|
|
|||
| if ('exportOutputs' in vpcConfig && typeof vpcConfig.createNatInstance === 'boolean') { | |||
There was a problem hiding this comment.
Thanks! Fixed in 6e4a867
# Conflicts: # README.md # __tests__/outputs.test.js # src/index.js
|
@jplock Rebased and fixed the issue you found. |
jplock
reviewed
Jul 21, 2019
src/outputs.js
Outdated
| if (exportOutputs) { | ||
| Object.entries(outputs).forEach(([name, value]) => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| value.Export = { Name: { '!Join': ['-', ["!Ref 'AWS::StackName'", name]] } }; |
There was a problem hiding this comment.
Can you use ‘Fn::Join’ here instead of !Join? Same with removing !Ref. Otherwise looks good
|
Can the package-lock changes be removed from this PR? |
jplock
approved these changes
Jul 22, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
So that one may consume the VPC's outputs from another stack.
Needed for cases where there are multiple Serverless services rather than a single one that require the same VPC setup.
Breaking changes?
None. A configuration to
exportOutputswas added, defaulting tofalse, preserving the current state of the plugin.Usage?
See readme for more details.