Allow the ModifiedTrait diff evaluator to take account traits added to #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newly added shapes
|
ModifiedTrait is more for traits that have been added, modified, or removed from existing shapes. Spoke offline and the recommended solution to provide diff events specifically for added waiters is a custom smithy diff evaluator, so closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newly added shapes: none
Issue #, if available:
Description of changes:
This allows the ModifiedTrait diff evaluator to consider traits that are added to newly added shapes. For our specific use case, we need to know about added waiters even when it's added as a part of a new operation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.