Rename .rn to .native #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
approved these changes
Mar 20, 2020
| @@ -47,7 +47,7 @@ | |||
|
|
|||
| AWS_SDK_STREAM_COLLECTOR_NODE("dependencies", "@aws-sdk/stream-collector-node", "^1.0.0-alpha.1", true), | |||
| AWS_SDK_STREAM_COLLECTOR_BROWSER("dependencies", "@aws-sdk/stream-collector-browser", "^1.0.0-alpha.1", true), | |||
| AWS_SDK_STREAM_COLLECTOR_RN("dependencies", "@aws-sdk/stream-collector-rn", "^1.0.0-alpha.0", true), | |||
| AWS_SDK_STREAM_COLLECTOR_RN("dependencies", "@aws-sdk/stream-collector-native", "^1.0.0-alpha.0", true), | |||
There was a problem hiding this comment.
Why is this necessary?
There was a problem hiding this comment.
Since we're preferring .native vs .rn extensions we should also move from -rn to -native package names.
Similar to .browser extension and -browser package name
There was a problem hiding this comment.
Relevant commit for updating package names in codegen aws/aws-sdk-js-v3@bb1e16b (part of PR aws/aws-sdk-js-v3#1025)
There was a problem hiding this comment.
I'm not apposing to it, but I don't think it's necessary either.🙂
AllanZhengYP
approved these changes
Mar 20, 2020
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Updates references of @aws to @AWS-SDK * Updates package versions to 0.1.0 * Updates package generator to generate packages with correct names and values * Remove private field from public packages * Fixes package generator when generating client packages * Sets client-documentation-generator package to private * Regenerate service packages * Removes old sdk-service packages * Fixes karma-credential-loader version * Updates readmes and sigv4 spec script * Adds prepublishOnly step to packages that were missing it * Fixes xml-body-builder package * Fixes tsconfig.json for util-error-constructor package * Fixes crypto package tsconfig.json files * Updates md5-js tsconfig
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
* Updates references of @aws to @AWS-SDK * Updates package versions to 0.1.0 * Updates package generator to generate packages with correct names and values * Remove private field from public packages * Fixes package generator when generating client packages * Sets client-documentation-generator package to private * Regenerate service packages * Removes old sdk-service packages * Fixes karma-credential-loader version * Updates readmes and sigv4 spec script * Adds prepublishOnly step to packages that were missing it * Fixes xml-body-builder package * Fixes tsconfig.json for util-error-constructor package * Fixes crypto package tsconfig.json files * Updates md5-js tsconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Refs: aws/aws-sdk-js-v3#990
Description of changes:
Rename .rn to .native
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.