-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: xml serde reduction #1108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/xml
branch
8 times, most recently
from
December 15, 2023 17:07
8e99897
to
d932dad
Compare
9 tasks
kuhe
commented
Dec 15, 2023
@@ -673,7 +677,9 @@ private void generateOperationRequestSerializer( | |||
// Get the hostname, path, port, and scheme from client's resolved endpoint. | |||
// Then construct the request from them. The client's resolved endpoint can | |||
// be default one or supplied by users. | |||
writer.write("const {hostname, protocol = $S, port, path: basePath} = await context.endpoint();", "https"); | |||
|
|||
writer.addImport("requestBuilder", "rb", TypeScriptDependency.SMITHY_CORE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requestBuilder is from #1107
mtdowling
reviewed
Dec 15, 2023
mtdowling
requested changes
Dec 15, 2023
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Dec 15, 2023
...script-codegen/src/main/java/software/amazon/smithy/typescript/codegen/util/StringStore.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Dec 15, 2023
syall
approved these changes
Dec 18, 2023
trivikr
approved these changes
Dec 18, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a class called
StringStore
, which allocates shortened variables for any given string.The basic idea is a transform of something like:
to
Real example from S3:
To answer some potential questions:
doesn't this make the code hard to read?
is the variable allocation deterministic?
does this affect tree-shaking?
esbuild
and only those variables being used are included in the bundle.what is the effect on protocol file sizes?
what about strings that only appear once?