Fix flaky test in aws-sigv4 #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was flaky because all invalid headers are counted as rejects which can in rare cases exceed the maximum number of failures.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Thanks for the fix! It looks like aws/rust-runtime/Cargo.lock being committed is a bit old with respect to the one in main, since many crates are being downgraded to older versions?
Merged the main branch and updated aws/rust-runtime/Cargo.lock, which looks good now.
drganjoo
approved these changes
Jan 30, 2025
ysaito1001
approved these changes
Jan 30, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The test was flaky because all invalid headers are counted as rejects which can in rare cases exceed the maximum number of failures.
The test was flaky because all invalid headers are counted as rejects which can in rare cases exceed the maximum number of failures.
Description
Change the test to assert that the validity status matches instead of filtering those cases out
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.