-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMDS retries #3975
IMDS retries #3975
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is still in draft so take feedback with grain of salt.
I'm wondering if we shouldn't expose the ability to customize the ImdsResponseRetryClassifier
so that users don't have to start from scratch when creating a client.
e.g. (with some pseudo code)
let imds = aws_config::imds::client::builder()
.with_retry_classifier(
ImdsResponseRetryClassifer::default()
.with_retry_connect_timeouts(true) // new API(s) to customize from the default we use today
)
...
.build()
Or if we are super paranoid keep it hidden and just add new options to the client builder for this behavior but I think I'd be ok either way.
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Appease Clippy Add external types
3671652
to
2aed9ff
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
Addressing awslabs/aws-sdk-rust#1233
Description
Add ability to configure the retry classifier on the IMDS client.
Testing
Added new unit test to ensure that a user defined retry classifer is being used.
Checklist
.changelog
directory, specifying "client," "server," or both in theapplies_to
key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.