Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pinning idna and url crates #3972

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

ysaito1001
Copy link
Contributor

Motivation and Context

Now that we're on MSRV 1.8.1 we can addresses these TODOs.

Testing

Manually ran

./gradlew aws:sdk:cargoUpdateAllLockfiles 

and bulit aws-sdk-s3 (can be any SDK crate) with updated idna and url crates:

➜  s3 git:(ysaito/remove-pinning-idna-and-url) ✗ cargo check --all-features
...
    Checking idna v1.0.3
...
    Checking url v2.5.4
...
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.56s

I didn't include updated lockfiles in this PR as they will be updated automatically next week by the bot's weekly PR to update lockfiles.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ysaito1001 ysaito1001 requested a review from a team as a code owner January 16, 2025 22:54
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly I had that TLS failure on my PR as well. First time I have seen that, but otherwise LGTM

@ysaito1001
Copy link
Contributor Author

Weirdly I had that TLS failure on my PR as well. First time I have seen that, but otherwise LGTM

Yeah, this looks like an across-the-board failure and related to BradenM/micropy-cli#575

@ysaito1001 ysaito1001 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 41ff31b Jan 17, 2025
42 of 44 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/remove-pinning-idna-and-url branch January 17, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants