Unpin xmlparser. #1877
Closed
Unpin xmlparser. #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velfi
approved these changes
Oct 19, 2022
|
@dvc94ch We originally added this pin because of an issue with escaping characters in references. I'm going to add a test to this PR before merging it to make sure we don't experience a regression. |
|
I created a separate PR to update the version to the latest and I also renamed a test that was named incorrectly. I'm going to close this PR and merge that one. Thanks @dvc94ch for uncovering this. |
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Dependencies shouldn't be pinned. It causes dependency resolution failures as cargo selects
0.13.6and then finds the constraint=0.13.3which it fails to resolve. Pinning dependencies is always a bad idea. Alternatively someone could improve the cargo version constraint solver.