-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change FindNextUnstartedTransactionFromAddress method signature #12124
change FindNextUnstartedTransactionFromAddress method signature #12124
Conversation
…replacing inplace
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
change the
FindNextUnstartedTransactionFromAddress
to return a transaction rather than replacing a passed in transaction. This was breaking linting rules and does not seem to have a benefit. It also does not seem to follow the patterns of other method signatures.