-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SetDefaultDigestAlgorithm
#29
Add SetDefaultDigestAlgorithm
#29
Conversation
I dont think its a good way to configure the digest alg like this. We should redesign the API, release a v2 of the package which passes the algorithm directly in the digest / encrypt operations. |
@stv0g I don't disagree with you 😛 The goal of this change is to keep the current logic intact, while having a backwards compatible change to support a better hashing algorithm if implementers choose to do so. It's fairly similar to existing knobs exposed in the package. We don't intend this to be the new API. |
+1 for this. I have a requirement to use AES256. Apple are no longer supporting SHA1 on some of their non-public verification APIs and we cannot implement their specification without this. |
There is already a |
It works, but that has to be called on every new instance of |
5ee55ff
to
9b402c9
Compare
0fd42b5
to
7003208
Compare
No description provided.