Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intune tutorial to fix UX gap #291

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Update Intune tutorial to fix UX gap #291

merged 2 commits into from
Dec 12, 2023

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Dec 4, 2023

No description provided.

@tashian tashian requested a review from a team as a code owner December 4, 2023 17:56
Copy link
Contributor

@Linda-Ikechukwu Linda-Ikechukwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Two things I noticed are (couldn't comment directly on the specific lines):

Step three, ### 3. Configure Smallstep needs to be changed to H2 to match other headings.

For separation of concerns and SEO reasons, and easier findability, I think it would be ideal to move the section on "Adding Wi-Fi Support" to a new page, and then link to where we have the phrase "This tutorial assumes you are configuring EAP-TLS Wi-Fi network access." or just link to it

@tashian tashian enabled auto-merge December 8, 2023 03:27
@tashian
Copy link
Contributor Author

tashian commented Dec 8, 2023

@Linda-Ikechukwu I've updated the tutorial based on your feedback, thanks. Could you give it another review? I didn't separate out the Wi-Fi bits yet, but it's a good idea for the future. For now I just want to get this out there. All of this is changing quickly and will continue to evolve as we automate more bits of the process.

@tashian tashian merged commit 798a13e into main Dec 12, 2023
1 check passed
@tashian tashian deleted the carl/intune-jamf-flow branch December 12, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants