-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post for slsa-github-generator generic GA #471
Blog post for slsa-github-generator generic GA #471
Conversation
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
eb26d4a
to
a1d5bcf
Compare
Adds a blog post about the slsa-github-generator generic workflow and it's general availability. This is a follow on to the previous blog post on slsa-github-generator's Go functionality published on Jun 20. Signed-off-by: Ian Lewis <[email protected]>
a1d5bcf
to
4ea7820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
Signed-off-by: Ian Lewis <[email protected]>
@MarkLodato is OOO. Any additional feedback? @joshuagl @kimsterv? |
Also would like approval from @asraa as well as her name is in the author line. |
Thanks everyone for the thorough reviews. Any further comments before we can merge this PR? |
Do you want to mention the recent pypi phishing and related unauthorized publishing of packages in the examples? Just a suggestion. no other comments from my side. |
We already have examples in the text, but we can add one more. Do you have a link in mind you think we should add? |
This one https://www.bleepingcomputer.com/news/security/pypi-packages-hijacked-after-developers-fall-for-phishing-emails/? I know there are already examples, which is why this might not be needed. At the same time, this is more recent and top of mind. |
Thank you @mlieberman85 for your review. I think this only needs one reviewer, but leaving for any other final comments from steering committee for another day (it was shared earlier in the week). |
I thought the same thing when this came out. I left the existing examples but added a note referencing this most recent incident. |
Signed-off-by: Ian Lewis <[email protected]>
c213b71
to
25d51b7
Compare
@inferno-chromium where was this blog draft shared? I don't believe there was a SLSA meeting last week, so trying to understand if it was in a different medium that I did not see. |
This was shared on both slsa and tac openssf slack and here in the repo. We haven't needed discussions in SLSA meetings before. Feel free to take a look and let us know how would like to proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: asraa <[email protected]> Signed-off-by: Ian Lewis <[email protected]>
Co-authored-by: asraa <[email protected]> Signed-off-by: Ian Lewis <[email protected]>
I see it now!! Thank you :) For some reason i didn't notice it (even though i posted right after it was shared) |
Adds a blog post about the slsa-github-generator generic workflow and
it's general availability. This is a follow on to the previous blog post
on slsa-github-generator's Go functionality published on Jun 20.
Signed-off-by: Ian Lewis <[email protected]>