EnvError should inherit from ValueError #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I feel like EnvError should inherit from ValueError instead of the generic Exception.
For instance,
env.int
of "foo" will raiseEnvError
, whileint("foo")
raisesValueError
.It seems to me that both
EnvError
andValueError
refer to an error inside the value that cannot be safely typecasted. SinceValueError
is just a generalization ofEnvError
,EnvError
should inherit from it.