Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Replace incorrect sprintf placeholders with default placeholders #2466

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Bug fix: Replace incorrect sprintf placeholders with default placeholders #2466

merged 1 commit into from
Jul 15, 2018

Conversation

llvdl
Copy link
Contributor

@llvdl llvdl commented Jul 9, 2018 •
edited by akrabat
Loading

Replaces incorrect sprintf placeholders with default placeholders. Fixes #2433.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.106% when pulling adcc4db on llvdl:gh-2433 into 1ca7859 on slimphp:3.x.

@akrabat akrabat added this to the 3.10.1 milestone Jul 15, 2018
@akrabat akrabat merged commit adcc4db into slimphp:3.x Jul 15, 2018
akrabat added a commit that referenced this pull request Jul 15, 2018
@akrabat
Merge branch 'llvdl-gh-2433' into 3.x
2eaf0dd 
Closes #2466
@akrabat
Copy link
Member

akrabat commented Jul 15, 2018

Thanks.

Is this needed on Slim-Http too?

@llvdl
Copy link
Contributor Author

llvdl commented Jul 16, 2018

Good call. Slim-Http needs to be updated as well. I will create a PR for Slim-Http after work.

@akrabat akrabat changed the title gh-2433 replaces incorrect sprintf placeholders with default placehol… Bug fix: Replace incorrect sprintf placeholders with default placeholders Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@llvdl @coveralls @akrabat