Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Make string comparison more strict in Slim\Http\Uri class #2449

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Bug Fix: Make string comparison more strict in Slim\Http\Uri class #2449

merged 1 commit into from
Jun 24, 2018

Conversation

nyamsprod
Copy link

This PR resolves the following bug in the Uri class:

<?php

use Slim\Http\Uri;
$uri = Uri::createFromString('https://0:0@0:1/0?0#0'); // display https://0:0@0:1'
// expected 'https://0:0@0:1/0?0#0'

$uri = Uri::createFromString('https://0:0@0:1/0?0#0')->getBaseUrl(); // display https://0:1'
// expected 'https://0:0@0:1'

All string comparison are made more strict now.

Maybe other PRs may look and fix this issue in other classes as well.
Also this could be backported to Slim\Http repository as well.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.105% when pulling e6917e1 on bakame-php:bugfix/uri-ToString-method into 0803c9e on slimphp:3.x.

@akrabat akrabat added this to the 3.10.1 milestone Jun 24, 2018
@akrabat akrabat merged commit e6917e1 into slimphp:3.x Jun 24, 2018
@akrabat
Copy link
Member

akrabat commented Jun 24, 2018

Thanks.

Please forward port to Slim\Http

@nyamsprod nyamsprod deleted the bugfix/uri-ToString-method branch June 25, 2018 06:24
@akrabat akrabat changed the title making string comparison more strict in Slim\Http\Uri class Bug Fix: Make string comparison more strict in Slim\Http\Uri class Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants