-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum php version to 7.0.0 #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrabat
reviewed
Sep 8, 2018
src/Uri.php
Outdated
if ($clone->user) { | ||
$clone->password = $password ? $this->filterUserInfo($password) : ''; | ||
if ($clone->user !== '') { | ||
$clone->password = $password !== '' ? $this->filterUserInfo($password) : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if null
is passed in for $password
?
I think we shouldn't change the specificity of the conditionals without also type hinting. |
Merged
211765a
to
fadfa3f
Compare
Rebased due to merge of the PRs. |
Turns out my comments were moot! |
Thanks @dbtlr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
Updates the minimum version requirement to PHP >= 7.0.0.
Also fixes some of the broken unit tests in PHP 7.1 and higher. These were due to two problems:
w
flag was used. Opted to just fix how tests were written to use file names instead.!== ''
checks instead.