Raise error if there is a token in the body of a GET request #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrabat
force-pushed
the
no-token-in-get-body
branch
2 times, most recently
from
ec16016 to
d1a0435
Compare
l0gicgate
requested changes
Jan 7, 2021
Methods such as GET should not be used for state change operations (RFC2616). If the body of a GET request has the token in it, then treat that as an error. Thanks to Xhelal Likaj (https://github.com/xhlika) for the report.
akrabat
force-pushed
the
no-token-in-get-body
branch
from
35a9ed6 to
99234ed
Compare
|
Rebased and removed additional blank line. |
l0gicgate
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods such as GET should not be used for state change operations (see RFC2616). If the body of a GET request has the token in it, then treat that as an error.
Thanks to @xhlika for the report.