Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling from tray icon even when strict mode is enabled #663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

undefiened
Copy link
Contributor

@undefiened undefiened commented Nov 11, 2024

I like the strict mode, but there are sometimes cases when I forget to disable the app before a presentation or something. Right now it is not possible to disable the app from the tray icon for 30 minutes after the notification that the screen will be locked within 15 seconds. Enabling this option in the tray icon plugin would allow disabling the app even after the notification.

@undefiened undefiened changed the title Allow forced disabling even when strict mode is enabled Allow disabling from tray icon even when strict mode is enabled Nov 11, 2024
Copy link
Collaborator

@deltragon deltragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure about this - if I understand correctly, the behaviour you are looking for is the "Skip" button being hidden, but that it is still possible to effectively skip the notification by just disabling SafeEyes in the tray?

I'm open to adding that as a possibility, but I'd rather it be a more understandable setting, than a "Strict break" mode that then has options to make it less strict again...
What about just adding a global button "Allow skipping breaks" (defaulting to true), the same way we have "Allow postponing breaks" - and "Strict break" being set means "Allow skipping breaks" gets unset. This seems the most intuitive in general, and your use-case is met by setting "Strict break" to false, and "Allow skipping breaks" to false as well.

@@ -65,7 +65,7 @@
{
"id": "audiblealert",
"enabled": true,
"version": "0.0.3",
"version": "0.0.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bump should probably be in "trayicon", not "audiblealert".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(If the rework I propose above happens, this comment is moot, of course.)

@undefiened
Copy link
Contributor Author

I am unsure about this - if I understand correctly, the behaviour you are looking for is the "Skip" button being hidden, but that it is still possible to effectively skip the notification by just disabling SafeEyes in the tray?

I'm open to adding that as a possibility, but I'd rather it be a more understandable setting, than a "Strict break" mode that then has options to make it less strict again... What about just adding a global button "Allow skipping breaks" (defaulting to true), the same way we have "Allow postponing breaks" - and "Strict break" being set means "Allow skipping breaks" gets unset. This seems the most intuitive in general, and your use-case is met by setting "Strict break" to false, and "Allow skipping breaks" to false as well.

Hmm, I like your idea. I will look into it! Thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants