Fix memory corruption in AVX-512 codepath #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the block size is not divisible by 64, we could overrun the buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AVX-512 codepath incorrectly calculates the end of the caller's buffer using
sizeof(__m256i)but the elements being processed are actuallysizeof(__m512i).As a result,
reed_solomon_encode()andreed_solomon_decode()may write outside the bounds of the caller's buffer for certain block sizes when compiled with AVX-512 optimizations enabled.This was originally reported in LizardByte/Sunshine#2543