Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ratelimiting introduced edge condition #332

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix ratelimiting introduced edge condition #332

merged 1 commit into from
Feb 14, 2025

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Feb 14, 2025

I missed an edge condition when we're ratelimiting that we might no longer respect routing protocols

This change continually retries the routing stack when routing to a worker which just finished a job, for each queue'd message, until either

  1. We route a message
  2. We flush the queue

this shouldn't impact anyone not using rate limiting as the rate limit result is impossible from the normal routing protocols.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (01e45fc) to head (97b40f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   82.19%   82.18%   -0.01%     
==========================================
  Files          64       64              
  Lines       12693    12692       -1     
==========================================
- Hits        10433    10431       -2     
- Misses       2260     2261       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slawlor slawlor marked this pull request as ready for review February 14, 2025 01:31
@slawlor slawlor merged commit 2f864f2 into main Feb 14, 2025
20 checks passed
@slawlor slawlor deleted the ratelim branch February 14, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant