Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly better netlink client tests #35

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Conversation

nbrownus
Copy link
Collaborator

@nbrownus nbrownus commented Aug 7, 2017

Provides better test-ability and error messages in tests that fail for the NetlinkClient

@codecov-io
Copy link

codecov-io commented Aug 7, 2017

Codecov Report

Merging #35 into master will decrease coverage by 0.38%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   75.04%   74.66%   -0.39%     
==========================================
  Files           5        5              
  Lines         589      592       +3     
==========================================
  Hits          442      442              
- Misses        133      136       +3     
  Partials       14       14
Impacted Files Coverage Δ
audit.go 75.54% <0%> (-0.84%) ⬇️
client.go 88.37% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3d335...963c344. Read the comment docs.

@alanhlam
Copy link

alanhlam commented Aug 8, 2017

👍

@nbrownus nbrownus force-pushed the better-client-test branch from 5d84d33 to 963c344 Compare August 8, 2017 22:04
@nbrownus nbrownus merged commit 01f125e into master Aug 8, 2017
@nbrownus nbrownus deleted the better-client-test branch August 8, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants