Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove celluloid code #355

Merged
merged 7 commits into from
Jan 11, 2021
Merged

Remove celluloid code #355

merged 7 commits into from
Jan 11, 2021

Conversation

wasabigeek
Copy link
Contributor

Partially addresses #338, removing Celluloid.

@dangerpr-bot
Copy link

dangerpr-bot commented Jan 9, 2021 •
edited
Loading

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@wasabigeek wasabigeek marked this pull request as ready for review January 9, 2021 10:09
@dblock dblock merged commit 911d7a8 into slack-ruby:master Jan 11, 2021
@wasabigeek wasabigeek deleted the remove-celluloid branch January 12, 2021 04:27
@blowfishpro blowfishpro mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wasabigeek @dangerpr-bot @dblock