Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New Methods #327

Merged
merged 7 commits into from
Jun 14, 2020
Merged

Update New Methods #327

merged 7 commits into from
Jun 14, 2020

Conversation

wasabigeek
Copy link
Contributor

@wasabigeek wasabigeek commented Jun 7, 2020

Minor doc changes to AdminConversations, and adds new AdminConversationsWhitelist methods. There are 3 more new sets of methods, should I open separate PRs for them?

Prereq to #320, follow-up on #326

@dangerpr-bot
Copy link

dangerpr-bot commented Jun 7, 2020

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 Danger

CHANGELOG.md Outdated Show resolved Hide resolved
@dblock
Copy link
Collaborator

dblock commented Jun 8, 2020

You have a legit build failure here, something's up.

@wasabigeek wasabigeek changed the title Update AdminConversations Update New Methods Jun 13, 2020
@wasabigeek
Copy link
Contributor Author

Hmm I ended up adding the other methods, is that ok? I now think I know the specific lines I was missing to stop the build failures, but figured it was ok to do it all - I didn't change the auto-generated methods, and the slack-api-ref was updated anyway.

@dblock dblock merged commit c04a831 into slack-ruby:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants