Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SWActionSheet.m #29

Merged
merged 1 commit into from
Aug 31, 2014
Merged

Update SWActionSheet.m #29

merged 1 commit into from
Aug 31, 2014

Conversation

TonSilver
Copy link

For origin use keyWindow.rootViewController.view or keyWindow. It is not correct to use last subview on keyWindow.

For origin use keyWindow.rootViewController.view or keyWindow. It is not correct to use last subview on keyWindow.
@TonSilver
Copy link
Author

Last subview may be invisible, hidden, somewhere outside, etc.

skywinder added a commit that referenced this pull request Aug 31, 2014
@skywinder skywinder merged commit 5133131 into skywinder:master Aug 31, 2014
@skywinder
Copy link
Owner

Correct. Thanks!

@skywinder
Copy link
Owner

@serebryakov-av Hi. Please look at #30.
It seems that your fix needs to be improved.

@skywinder
Copy link
Owner

In which case keyWindow will be wrong view and we need to use keyWindow.rootViewController.view?

@TonSilver
Copy link
Author

I think in case when device orientation is not portrait.

@skywinder
Copy link
Owner

@serebryakov-av Yes, you're right. But this feature broke picker presentation in modal view (so, I that's why I use lastObject. (see #31)
You can reproduce it in example project, when run modal view from iPhone simulator.

Any ideas how to fix it?

@TonSilver
Copy link
Author

Ok, I will try.

@TonSilver
Copy link
Author

I have the solution! I will push it in one hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants